netdev - RE: create drivers/net/mdio and move mdio drivers into it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8729016553E3654398EA69218DA29EEF15A807CA@cnshjmbx02>
Date:   Mon, 20 Feb 2017 05:23:46 +0000
From:   YUAN Linyu <Linyu.Yuan@...atel-sbell.com.cn>
To:     Florian Fainelli <f.fainelli@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Andrew Lunn <andrew@...n.ch>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "cugyly@....com" <cugyly@....com>
Subject: RE: create drivers/net/mdio and move mdio drivers into it

1. the main issue is mdio driver mixed with phy driver/ethernet driver.
2. move them together, it's easy to maintain, add, delete or optimization(we can do it step by step).

3. another idea is bind mdio device to network device
4. support mdio auto probe phy device.
For 3, 4 can take device tree as example,
Current,
			ethernet@...00 {
				phy-handle = <&rgmii_phy1>;
				phy-connection-type = "rgmii";
			};

			ethernet@...00 {
				phy-handle = <&rgmii_phy2>;
				phy-connection-type = "rgmii";
			};

			mdio@...00 {
				rgmii_phy1: ethernet-phy@1 {
					reg = <0x1>;
				};
				rgmii_phy2: ethernet-phy@2 {
					reg = <0x2>;
				};
			};
After change,
			ethernet@...00 {
				mdio-handle = <&mdio>;
				phy-reg = <0x1>;
				phy-connection-type = "rgmii";
			};

			ethernet@...00 {
				mdio-handle = <&mdio>;
				phy-handle = <&rgmii_phy2>;
				phy-connection-type = "rgmii";
			};

			mdio: mdio@...00 {
			    reg = <xxx>;
			};


> -----Original Message-----
> From: Florian Fainelli [mailto:f.fainelli@...il.com]
> Sent: Monday, February 20, 2017 1:03 PM
> To: YUAN Linyu; David S . Miller; Andrew Lunn
> Cc: netdev@...r.kernel.org; cugyly@....com
> Subject: Re: create drivers/net/mdio and move mdio drivers into it
> 
> 
> 
> On 02/19/2017 04:20 PM, YUAN Linyu wrote:
> > Hi,
> >
> > I have an idea to create drivers/net/mdio and move mdio
> drivers(drivers/net/phy/mdio-* | drivers/net/ethernet/xxx/mdio-yyy | ) into it.
> >
> > Do you think it is acceptable ?
> 
> What problem are you trying to fix by doing such a move? Moving files
> around mean that making stable backports are going to be much more painful.
> 
> So without further explanation, does not sound like such a great idea.
> --
> Florian