netdev - Re: [PATCH] net: aquantia: remove function aq_ring_tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170220.102353.2285049503711848984.davem@davemloft.net>
Date:   Mon, 20 Feb 2017 10:23:53 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     LinoSanfilippo@....de
Cc:     Simon.Edelhaus@...antia.com, Pavel.Belous@...antia.com,
        Alexey.Andriyanov@...antia.com, netdev@...r.kernel.org
Subject: Re: [PATCH] net: aquantia: remove function aq_ring_tx_deinit

From: Lino Sanfilippo <LinoSanfilippo@....de>
Date: Sat, 18 Feb 2017 12:27:12 +0100

> Both functions aq_ring_rx_deinit() and aq_ring_tx_clean() are almost
> identical aside from an additional check in the latter.
> Move that check from the function into its caller and replace
> aq_ring_rx_deinit() with aq_ring_rx_deinit().
> 
> By doing this also adjust the functions return value from int to void
> since it can never fail.
> 
> Signed-off-by: Lino Sanfilippo <LinoSanfilippo@....de>

Applied.