netdev - Re: [PATCH net-next 2/2] bpf: fix unlocking of jited image when module ronx not set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAF=yD-LQxhhMd0-cZVoC_jQiPVf+TU1hakFwgB2E=ndS+HBmwg@mail.gmail.com>
Date:   Tue, 21 Feb 2017 11:32:38 -0500
From:   Willem de Bruijn <willemdebruijn.kernel@...il.com>
To:     Daniel Borkmann <daniel@...earbox.net>
Cc:     David Miller <davem@...emloft.net>,
        Alexei Starovoitov <ast@...nel.org>, labbott@...hat.com,
        Eric Dumazet <eric.dumazet@...il.com>,
        Willem de Bruijn <willemb@...gle.com>,
        Network Development <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 2/2] bpf: fix unlocking of jited image when
 module ronx not set

On Tue, Feb 21, 2017 at 10:09 AM, Daniel Borkmann <daniel@...earbox.net> wrote:
> Eric and Willem reported that they recently saw random crashes when
> JIT was in use and bisected this to 74451e66d516 ("bpf: make jited
> programs visible in traces"). Issue was that the consolidation part
> added bpf_jit_binary_unlock_ro() that would unlock previously made
> read-only memory back to read-write. However, DEBUG_SET_MODULE_RONX
> cannot be used for this to test for presence of set_memory_*()
> functions. We need to use ARCH_HAS_SET_MEMORY instead to fix this;
> also add the corresponding bpf_jit_binary_lock_ro() to filter.h.
>
> Fixes: 74451e66d516 ("bpf: make jited programs visible in traces")
> Reported-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: Willem de Bruijn <willemb@...gle.com>
> Bisected-by: Eric Dumazet <edumazet@...gle.com>
> Signed-off-by: Daniel Borkmann <daniel@...earbox.net>

This fixes the issue I observed. Thanks, Daniel.

Tested-by: Willem de Bruijn <willemb@...gle.com>