netdev - Re: Focusing the XDP project

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170221.114617.1686255511436946338.davem@davemloft.net>
Date:   Tue, 21 Feb 2017 11:46:17 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     tom@...bertland.com
Cc:     saeedm@...lanox.com, alexander.duyck@...il.com, brouer@...hat.com,
        alexei.starovoitov@...il.com, john.fastabend@...il.com,
        netdev@...r.kernel.org, bblanco@...il.com
Subject: Re: Focusing the XDP project

From: Tom Herbert <tom@...bertland.com>
Date: Tue, 21 Feb 2017 08:35:41 -0800

> We already have good APIs for similar datapath functionality (GRO,
> GSO, xmit_more, etc.), and I don't see why XDP is so special that we
> can't come up with a reasonable API for batching and implement it.

What you are missing is that it wasn't always this way.

The initial TSO support was a hodge-podge of weird driver APIs and
simple heuristics thrown all over the place.  It was ugly but worked
and allowed us to experiment.  We had to adjust driver internals
a lot until on the way towards getting things how they are today.

This is the natural course of things, so please don't suggest that XDP
shouldn't evolve in the same way.

I think we really need to be fast and loose right now and only try to
constrict and perfect the API after some of this initial activity has
died down.

Yes it's more work for the brave drivers that add XDP support, but
unfortunately that's how we figure out what's really needed and works
in the long term.