netdev - Re: [PATCH net v2] ip: fix IP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170221.122626.706529426465404504.davem@davemloft.net>
Date:   Tue, 21 Feb 2017 12:26:26 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     pabeni@...hat.com
Cc:     netdev@...r.kernel.org, andreyknvl@...gle.com, edumazet@...gle.com,
        tom@...bertland.com, stephen@...workplumber.org
Subject: Re: [PATCH net v2] ip: fix IP_CHECKSUM handling

From: Paolo Abeni <pabeni@...hat.com>
Date: Tue, 21 Feb 2017 09:33:18 +0100

> The skbs processed by ip_cmsg_recv() are not guaranteed to
> be linear e.g. when sending UDP packets over loopback with
> MSGMORE.
> Using csum_partial() on [potentially] the whole skb len
> is dangerous; instead be on the safe side and use skb_checksum().
> 
> Thanks to syzkaller team to detect the issue and provide the
> reproducer.
> 
> v1 -> v2:
>  - move the variable declaration in a tighter scope
> 
> Fixes: ad6f939ab193 ("ip: Add offset parameter to ip_cmsg_recv")
> Reported-by: Andrey Konovalov <andreyknvl@...gle.com>
> Signed-off-by: Paolo Abeni <pabeni@...hat.com>

Applied and queued up for -stable, thanks.