netdev - Re: [PATCH] net: socket: fix recvmmsg not returning error from sock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170221.133558.1628815110115665532.davem@davemloft.net>
Date:   Tue, 21 Feb 2017 13:35:58 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     maxime.jayat@...ile-devices.fr
Cc:     acme@...hat.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: socket: fix recvmmsg not returning error from
 sock_error

From: Maxime Jayat <maxime.jayat@...ile-devices.fr>
Date: Tue, 21 Feb 2017 18:35:51 +0100

> Commit 34b88a68f26a ("net: Fix use after free in the recvmmsg exit path"),
> changed the exit path of recvmmsg to always return the datagrams
> variable and modified the error paths to set the variable to the error
> code returned by recvmsg if necessary.
> 
> However in the case sock_error returned an error, the error code was
> then ignored, and recvmmsg returned 0.
> 
> Change the error path of recvmmsg to correctly return the error code
> of sock_error.
> 
> The bug was triggered by using recvmmsg on a CAN interface which was
> not up. Linux 4.6 and later return 0 in this case while earlier
> releases returned -ENETDOWN.
> 
> Fixes: 34b88a68f26a ("net: Fix use after free in the recvmmsg exit path")
> Signed-off-by: Maxime Jayat <maxime.jayat@...ile-devices.fr>

Good catch, applied and queued up for -stable.