netdev - Re: [PATCH net-next 1/1] net: sock: Use USEC_PER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+6hz4rYW+cghnEtObUD=-ZGHE7Lwc1Q+VE23QU4-RKNfY8LZw@mail.gmail.com>
Date:   Tue, 21 Feb 2017 15:23:52 +0800
From:   Feng Gao <gfree.wind@...il.com>
To:     Joe Perches <joe@...ches.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>, soheil@...gle.com,
        Linux Kernel Network Developers <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 1/1] net: sock: Use USEC_PER_SEC macro instead of
 literal 1000000

On Tue, Feb 21, 2017 at 3:13 PM, Joe Perches <joe@...ches.com> wrote:
> On Mon, 2017-02-20 at 22:33 +0800, fgao@...ai8.com wrote:
>> From: Gao Feng <fgao@...ai8.com>
>>
>> The USEC_PER_SEC is used once in sock_set_timeout as the max value of
>> tv_usec. But there are other similar codes which use the literal
>> 1000000 in this file.
>> It is minor cleanup to keep consitent.
> []
>> diff --git a/net/core/sock.c b/net/core/sock.c
> []
>> @@ -367,7 +367,7 @@ static int sock_set_timeout(long *timeo_p, char __user *optval, int optlen)
>>       if (tv.tv_sec == 0 && tv.tv_usec == 0)
>>               return 0;
>>       if (tv.tv_sec < (MAX_SCHEDULE_TIMEOUT/HZ - 1))
>> -             *timeo_p = tv.tv_sec*HZ + (tv.tv_usec+(1000000/HZ-1))/(1000000/HZ);
>> +             *timeo_p = tv.tv_sec * HZ + (tv.tv_usec + (USEC_PER_SEC / HZ - 1)) / (USEC_PER_SEC / HZ);
>
> Maybe convert this to DIV_ROUND_UP one day too?
>
>         *timeo_p = tv.tv_sec * HZ + DIV_ROUND_UP(tv.tv_usec, USEC_PER_SEC / HZ);
>

Good idea, thanks.
I would send v2 update.

Regards
Feng