netdev - Re: [PATCH net-next] can: initial support for network namespaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2bb24622-4387-f7cd-5c32-363840a69ae5@kicherer.org>
Date:   Tue, 21 Feb 2017 12:25:12 +0100
From:   Mario Kicherer <dev@...herer.org>
To:     Oliver Hartkopp <socketcan@...tkopp.net>
Cc:     netdev@...r.kernel.org,
        "linux-can@...r.kernel.org" <linux-can@...r.kernel.org>
Subject: Re: [PATCH net-next] can: initial support for network namespaces

Hello Oliver,

I just sent a v2 patch to all the required recipients.

I do not have a plan yet but virtual CAN links are also of interest to me. However,
I first wanted to check if this initial patch is acceptable before looking at this
topic.

Best regards,
Mario

On 16.02.2017 14:47, Oliver Hartkopp wrote:
> Hello Mario,
> 
> thanks for your patch.
> 
> On 02/16/2017 12:39 PM, Mario Kicherer wrote:
>> This patch adds initial support for network namespaces. The changes only
>> enable support in the CAN raw, proc and af_can code. GW and BCM still
>> have their checks that ensure that they are used only from the main
>> namespace.
>>
>> The patch boils down to moving the global structures, i.e. the global
>> filter list and their /proc stats, into a per-namespace structure and passing
>> around the corresponding "struct net" in a lot of different places.
>>
>> Signed-off-by: Mario Kicherer <dev@...herer.org>
> 
> Although it does not apply on the latest kernel due to this patch:
> 
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=f1712c73714088a7252d276a57126d56c7d37e64
> 
> Please rebase your patch to the latest kernel tree and post it again.
> 
> Additionally you should post CAN related stuff to the linux-can ML (see CC) and the CAN maintainers found in the MAINTAINERS file. In this case cross posting to netdev ML is fine as namespaces are very netdev related.
> 
> Do you have an idea how to go with namespace aware virtual CAN interfaces to link the namespaces?
> 
> Regards,
> Oliver
>