netdev - [PATCH] fjes: Move fjes driver info message into fjes_acpi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <210dfe59-18a0-4678-0a63-6751f21f0eb5@gmail.com>
Date:   Wed, 22 Feb 2017 15:40:49 -0500
From:   Yasuaki Ishimatsu <yasu.isimatu@...il.com>
To:     netdev@...r.kernel.org
Cc:     davem@...emloft.net, izumi.taku@...fujitsu.com
Subject: [PATCH] fjes: Move fjes driver info message into fjes_acpi_add()

The fjes driver is used only by FUJITSU servers and almost of all
servers in the world never use it. But currently if ACPI PNP0C02
is defined in the ACPI table, the following message is always shown:

  "FUJITSU Extended Socket Network Device Driver - version 1.2
   - Copyright (c) 2015 FUJITSU LIMITED"

The message makes users confused because there is no reason that
the message is shown in other vendor servers.

To avoid the confusion, the patch moves the message into
fjes_acpi_add() so that it is shows only when fjes_acpi_add()
succeeded.

Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@...fujitsu.com>
CC: Taku Izumi <izumi.taku@...fujitsu.com>
---
  drivers/net/fjes/fjes_main.c | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/fjes/fjes_main.c b/drivers/net/fjes/fjes_main.c
index b77e4ecf..8e1329c 100644
--- a/drivers/net/fjes/fjes_main.c
+++ b/drivers/net/fjes/fjes_main.c
@@ -151,6 +151,9 @@ static int fjes_acpi_add(struct acpi_device *device)
  						   ARRAY_SIZE(fjes_resource));
  	device->driver_data = plat_dev;

+	pr_info("%s - version %s - %s\n",
+		fjes_driver_string, fjes_driver_version, fjes_copyright);
+
  	return 0;
  }

@@ -1481,9 +1484,6 @@ static int __init fjes_init_module(void)
  {
  	int result;

-	pr_info("%s - version %s - %s\n",
-		fjes_driver_string, fjes_driver_version, fjes_copyright);
-
  	fjes_dbg_init();

  	result = platform_driver_register(&fjes_driver);
-- 
1.8.3.1