netdev - Re: [PATCH v2] net/dccp: fix use after free in tw_timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170222.161538.2214724719402158538.davem@davemloft.net>
Date:   Wed, 22 Feb 2017 16:15:38 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     aryabinin@...tuozzo.com
Cc:     gerrit@....abdn.ac.uk, edumazet@...gle.com, acme@...nel.org,
        dccp@...r.kernel.org, dvyukov@...gle.com, xiyou.wangcong@...il.com,
        kuznet@....inr.ac.ru, yoshfuji@...ux-ipv6.org, kaber@...sh.net,
        syzkaller@...glegroups.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] net/dccp: fix use after free in tw_timer_handler()

From: Andrey Ryabinin <aryabinin@...tuozzo.com>
Date: Wed, 22 Feb 2017 12:35:27 +0300

> DCCP doesn't purge timewait sockets on network namespace shutdown.
> So, after net namespace destroyed we could still have an active timer
> which will trigger use after free in tw_timer_handler():
 ...
> Add .exit_batch hook to dccp_v4_ops()/dccp_v6_ops() which will purge
> timewait sockets on net namespace destruction and prevent above issue.
> 
> Fixes: f2bf415cfed7 ("mib: add net to NET_ADD_STATS_BH")
> Reported-by: Dmitry Vyukov <dvyukov@...gle.com>
> Signed-off-by: Andrey Ryabinin <aryabinin@...tuozzo.com>
> Acked-by: Arnaldo Carvalho de Melo <acme@...hat.com>

Applied and queued up for -sable, thanks.