netdev - Re: create drivers/net/mdio and move mdio drivers into it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170222102109.GB18705@lunn.ch>
Date:   Wed, 22 Feb 2017 11:21:09 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     YUAN Linyu <Linyu.Yuan@...atel-sbell.com.cn>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "cugyly@....com" <cugyly@....com>
Subject: Re: create drivers/net/mdio and move mdio drivers into it

On Wed, Feb 22, 2017 at 05:38:49AM +0000, YUAN Linyu wrote:
> Hi Florian,
> 
> 1. 
> Let's go back to original topic,
> Can we move all mdio dirvers into drivers/net/mdio ?

Hi Yuan

Please could you explain what benefit this brings. Please also list
all the downsides for such a move. As Florian said, we need to ensure
such a move adds more value than it removes.

> Per may understanding, 
> I don't know why create a struct mii_bus instance to represent a mdio device in current mdio driver.
> Why not create a struct mdio_device instance, it's easy to understand.
> (We can move part of member of mii_bus to mdio_device).

Please take a step back. What are you trying to achieve. What is the
big picture. What cannot you do with the current design?

    Andrew