netdev - Re: [PATCH net-next] l2tp: Avoid schedule while atomic in exit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 22 Feb 2017 13:09:26 +0100
From:   Guillaume Nault <g.nault@...halink.fr>
To:     Ridge Kennedy <ridge.kennedy@...iedtelesis.co.nz>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net-next] l2tp: Avoid schedule while atomic in exit_net

On Wed, Feb 22, 2017 at 02:59:49PM +1300, Ridge Kennedy wrote:
> While destroying a network namespace that contains a L2TP tunnel a
> "BUG: scheduling while atomic" can be observed.

> To fix this, move the call to l2tp_tunnel_closeall() out of the RCU
> critical section, and instead call it from l2tp_tunnel_del_work(), which
> is running from the l2tp_wq workqueue.
> 
Looks good, though this should be for net, not net-next.

Acked-by: Guillaume Nault <g.nault@...halink.fr>