netdev - Re: [PATCH iproute2] tc: flower: Fix parsing ip address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170222151631.GA8047@penelope.horms.nl>
Date:   Wed, 22 Feb 2017 16:16:32 +0100
From:   Simon Horman <simon.horman@...ronome.com>
To:     Roi Dayan <roid@...lanox.com>
Cc:     Stephen Hemminger <stephen@...workplumber.org>,
        netdev@...r.kernel.org, Paul Blakey <paulb@...lanox.com>,
        Or Gerlitz <ogerlitz@...lanox.com>,
        Hadar Hen Zion <hadarh@...lanox.com>,
        Shahar Klein <shahark@...lanox.com>,
        Mark Bloch <markb@...lanox.com>, Jiri Pirko <jiri@...lanox.com>
Subject: Re: [PATCH iproute2] tc: flower: Fix parsing ip address

On Wed, Feb 22, 2017 at 04:05:01PM +0200, Roi Dayan wrote:
> Fix order of arguments when passed to __flower_parse_ip_addr.
> 
> Fixes: ("f888f4e20534 tc: flower: Support matching ARP")
> Signed-off-by: Roi Dayan <roid@...lanox.com>
> Reviewed-by: Paul Blakey <paulb@...lanox.com>

Reviewed-by: Simon Horman <simon.horman@...ronome.com>

> ---
>  tc/f_flower.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tc/f_flower.c b/tc/f_flower.c
> index 6bd03f2..5aac4a0 100644
> --- a/tc/f_flower.c
> +++ b/tc/f_flower.c
> @@ -289,8 +289,8 @@ static int flower_parse_ip_addr(char *str, __be16 eth_type,
>  		return -1;
>  	}
>  
> -	return __flower_parse_ip_addr(str, family, addr4_type, addr6_type,
> -				      mask4_type, mask6_type, n);
> +	return __flower_parse_ip_addr(str, family, addr4_type, mask4_type,
> +				      addr6_type, mask6_type, n);
>  }
>  
>  static bool flower_eth_type_arp(__be16 eth_type)
> -- 
> 2.7.4
>