netdev - Re: [PATCH net] vxlan: don't allow overwrite of config src addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170223170329.1623bf53@griffin>
Date:   Thu, 23 Feb 2017 17:03:29 +0100
From:   Jiri Benc <jbenc@...hat.com>
To:     Brian Russell <brussell@...cade.com>
Cc:     <netdev@...r.kernel.org>
Subject: Re: [PATCH net] vxlan: don't allow overwrite of config src addr

On Mon, 20 Feb 2017 17:25:28 +0000, Brian Russell wrote:
> When using IPv6 transport and a default dst, a pointer to the configured
> source address is passed into the route lookup. If no source address is
> configured, then the value is overwritten.
> 
> IPv6 route lookup ignores egress ifindex match if the source adress is set,
> so if egress ifindex match is desired, the source address must be passed
> as any. The overwrite breaks this for subsequent lookups.
> 
> Avoid this by copying the configured address to an existing stack variable
> and pass a pointer to that instead.

Seems there were another patches applied between the time you created
the patch and sent it and it doesn't apply.

Feel free to add to v2:

Acked-by: Jiri Benc <jbenc@...hat.com>

 Jiri