netdev - Re: [PATCH 00/35] treewide trivial patches converting pr_warning to pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACvgo50LUm5VSn_F=Dh8kL5zCPpCQDoCyUEL=Z+=1+6hJpfTaw@mail.gmail.com>
Date:   Thu, 23 Feb 2017 17:41:20 +0000
From:   Emil Velikov <emil.l.velikov@...il.com>
To:     Joe Perches <joe@...ches.com>
Cc:     Rob Herring <robh@...nel.org>,
        "linux-fbdev@...r.kernel.org" <linux-fbdev@...r.kernel.org>,
        linux-ia64@...r.kernel.org, SH-Linux <linux-sh@...r.kernel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        ML nouveau <nouveau@...ts.freedesktop.org>,
        Linux-ALSA <alsa-devel@...a-project.org>,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        "open list:VIRTIO GPU DRIVER" 
        <virtualization@...ts.linux-foundation.org>,
        "linux-ide@...r.kernel.org" <linux-ide@...r.kernel.org>,
        "linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>,
        sparclinux@...r.kernel.org, drbd-dev@...ts.linbit.com,
        linux-scsi@...r.kernel.org, Richard Weinberger <richard@....at>,
        sfi-devel@...plefirmware.org,
        amd-gfx mailing list <amd-gfx@...ts.freedesktop.org>,
        "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
        tboot-devel@...ts.sourceforge.net, oprofile-list@...ts.sf.net,
        "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
        xen-devel@...ts.xenproject.org,
        "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
        platform-driver-x86@...r.kernel.org,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        gigaset307x-common@...ts.sourceforge.net,
        acpi4asus-user@...ts.sourceforge.net,
        adi-buildroot-devel@...ts.sourceforge.net,
        Pekka Paalanen <ppaalanen@...il.com>,
        linux-omap <linux-omap@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        netdev <netdev@...r.kernel.org>,
        Karol Herbst <karolherbst@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        linux-crypto@...r.kernel.org, linux-alpha@...r.kernel.org,
        Fabio Estevam <fabio.estevam@....com>,
        linuxppc-dev <linuxppc-dev@...ts.ozlabs.org>
Subject: Re: [PATCH 00/35] treewide trivial patches converting pr_warning to pr_warn

On 23 February 2017 at 17:18, Joe Perches <joe@...ches.com> wrote:
> On Thu, 2017-02-23 at 09:28 -0600, Rob Herring wrote:
>> On Fri, Feb 17, 2017 at 1:11 AM, Joe Perches <joe@...ches.com> wrote:
>> > There are ~4300 uses of pr_warn and ~250 uses of the older
>> > pr_warning in the kernel source tree.
>> >
>> > Make the use of pr_warn consistent across all kernel files.
>> >
>> > This excludes all files in tools/ as there is a separate
>> > define pr_warning for that directory tree and pr_warn is
>> > not used in tools/.
>> >
>> > Done with 'sed s/\bpr_warning\b/pr_warn/' and some emacsing.
> []
>> Where's the removal of pr_warning so we don't have more sneak in?
>
> After all of these actually get applied,
> and maybe a cycle or two later, one would
> get sent.
>
By which point you'll get a few reincarnation of it. So you'll have to
do the same exercise again :-(

I guess the question is - are you expecting to get the series merged
all together/via one tree ? If not, your plan is perfectly reasonable.
Fwiw in the DRM subsystem, similar cleanups does purge the respective
macros/other with the final commit. But there one can pull the lot in
one go.

Regards,
Emil