netdev - Re: [PATCH net 1/1] tipc: move premature initilalization of stack variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170224.111348.761299008707145759.davem@davemloft.net>
Date:   Fri, 24 Feb 2017 11:13:48 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     jon.maloy@...csson.com
Cc:     netdev@...r.kernel.org, parthasarathy.bhuvaragan@...csson.com,
        ying.xue@...driver.com, maloy@...jonn.com,
        tipc-discussion@...ts.sourceforge.net
Subject: Re: [PATCH net 1/1] tipc: move premature initilalization of stack
 variables

From: Jon Maloy <jon.maloy@...csson.com>
Date: Thu, 23 Feb 2017 11:10:31 -0500

> In the function tipc_rcv() we initialize a couple of stack variables
> from the message header before that same header has been validated.
> In rare cases when the arriving header is non-linar, the validation
> function itself may linearize the buffer by calling skb_may_pull(),
> while the wrongly initialized stack fields are not updated accordingly.
> 
> We fix this in this commit.
> 
> Reported-by: Matthew Wong <mwong@...usnet.com>
> Signed-off-by: Jon Maloy <jon.maloy@...csson.com>

Applied.