netdev - Re: [PATCH] bridge: Add support for IEEE 802.11 Proxy ARP for IPv6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170224115537.160609db@xeon-e3>
Date:   Fri, 24 Feb 2017 11:55:37 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Jouni Malinen <jouni@...eaurora.org>
Cc:     David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH] bridge: Add support for IEEE 802.11 Proxy ARP for IPv6

The concept is fine.

Please add some comments to the code about what is happening and why.
The proposed patch is too sparse and has no comments.

> +	skb = alloc_skb(hlen + sizeof(struct ipv6hdr) + sizeof(*msg) +
> +			ndisc_opt_addr_space(dev,
> +					     NDISC_NEIGHBOUR_ADVERTISEMENT) +
> +			tlen, GFP_ATOMIC);
> +	if (!skb)
> +		return;

Why not netdev_alloc_skb which takes care of padding and setting skb->dev? 

Rather than doing copy/paste of the code to generate a ND message, it would
be better to have one function in IPv6 code that handles that. That would keep
from having to fix code in two places in the future. Is there some way
to extend ndisc_send_na?