lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 26 Feb 2017 19:28:03 +0200 From: Tariq Toukan <ttoukan.linux@...il.com> To: Eric Dumazet <eric.dumazet@...il.com>, David Miller <davem@...emloft.net> Cc: netdev <netdev@...r.kernel.org>, Eugenia Emantayev <eugenia@...lanox.com>, Tariq Toukan <tariqt@...lanox.com> Subject: Re: [PATCH net] net/mlx4_en: fix overflow in mlx4_en_init_timestamp() On 24/02/2017 1:22 AM, Eric Dumazet wrote: > From: Eric Dumazet <edumazet@...gle.com> > > The cited commit makes a great job of finding optimal shift/multiplier > values assuming a 10 seconds wrap around, but forgot to change the > overflow_period computation. > > It overflows in cyclecounter_cyc2ns(), and the final result is 804 ms, > which is silly. > > Lets simply use 5 seconds, no need to recompute this, given how it is > supposed to work. > > Later, we will use a timer instead of a work queue, since the new RX > allocation schem will no longer need mlx4_en_recover_from_oom() and the > service_task firing every 250 ms. > > Fixes: 31c128b66e5b ("net/mlx4_en: Choose time-stamping shift value according to HW frequency") > Signed-off-by: Eric Dumazet <edumazet@...gle.com> > Cc: Tariq Toukan <tariqt@...lanox.com> > Cc: Eugenia Emantayev <eugenia@...lanox.com> > --- > drivers/net/ethernet/mellanox/mlx4/en_clock.c | 18 +++++++--------- > drivers/net/ethernet/mellanox/mlx4/mlx4_en.h | 1 > 2 files changed, 8 insertions(+), 11 deletions(-) > Reviewed-by: Tariq Toukan <tariqt@...lanox.com> Thanks for your patch.
Powered by blists - more mailing lists