netdev - Re: [PATCH net-next 4/6] drivers: net: xgene-v2: Add base driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKh23FnRaGh0Hg0a1mb12CirEtW3RDdj=01-3RKGqycQP6H+Lw@mail.gmail.com>
Date:   Sun, 26 Feb 2017 20:33:23 -0800
From:   Iyappan Subramanian <isubramanian@....com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     David Miller <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>, patches <patches@....com>,
        Keyur Chudgar <kchudgar@....com>
Subject: Re: [PATCH net-next 4/6] drivers: net: xgene-v2: Add base driver

Hi Andrew,

On Tue, Jan 31, 2017 at 12:01 PM, Andrew Lunn <andrew@...n.ch> wrote:
>> +     phy_mode = device_get_phy_mode(dev);
>> +     if (phy_mode < 0) {
>> +             dev_err(dev, "Unable to get phy-connection-type\n");
>> +             return phy_mode;
>> +     }
>> +     pdata->resources.phy_mode = phy_mode;
>> +
>> +     if (pdata->resources.phy_mode != PHY_INTERFACE_MODE_RGMII) {
>> +             dev_err(dev, "Incorrect phy-connection-type specified\n");
>> +             return -ENODEV;
>> +     }
>
> This seems a bit limiting. What if you need to use:
>
> PHY_INTERFACE_MODE_RGMII_ID,
> PHY_INTERFACE_MODE_RGMII_RXID,
> PHY_INTERFACE_MODE_RGMII_TXID,
>
> in order to set the RGMII delays.

This version of the driver doesn't support setting delays.  The delay
support will be added in the future.

>
>    Andrew
>