netdev - Re: [PATCH 1/1] rds: ib: add the static type to the variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170228072017.GA3678@yuval-lap.uk.oracle.com>
Date:   Tue, 28 Feb 2017 09:20:18 +0200
From:   Yuval Shaia <yuval.shaia@...cle.com>
To:     Zhu Yanjun <yanjun.zhu@...cle.com>
Cc:     santosh.shilimkar@...cle.com, netdev@...r.kernel.org,
        linux-rdma@...r.kernel.org, rds-devel@....oracle.com,
        davem@...emloft.net
Subject: Re: [PATCH 1/1] rds: ib: add the static type to the variables

On Tue, Feb 28, 2017 at 01:45:40AM -0500, Zhu Yanjun wrote:
> The variables rds_ib_mr_1m_pool_size and rds_ib_mr_8k_pool_size
> are used only in the ib.c file. As such, the static type is
> added to limit them in this file.
> 
> Cc: Joe Jin <joe.jin@...cle.com>
> Cc: Junxiao Bi <junxiao.bi@...cle.com>
> Signed-off-by: Zhu Yanjun <yanjun.zhu@...cle.com>
> ---
>  net/rds/ib.c    | 4 ++--
>  net/rds/ib_mr.h | 2 --
>  2 files changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/net/rds/ib.c b/net/rds/ib.c
> index 8d70884..ecff01b 100644
> --- a/net/rds/ib.c
> +++ b/net/rds/ib.c
> @@ -45,8 +45,8 @@
>  #include "ib.h"
>  #include "ib_mr.h"
>  
> -unsigned int rds_ib_mr_1m_pool_size = RDS_MR_1M_POOL_SIZE;
> -unsigned int rds_ib_mr_8k_pool_size = RDS_MR_8K_POOL_SIZE;
> +static unsigned int rds_ib_mr_1m_pool_size = RDS_MR_1M_POOL_SIZE;
> +static unsigned int rds_ib_mr_8k_pool_size = RDS_MR_8K_POOL_SIZE;
>  unsigned int rds_ib_retry_count = RDS_IB_DEFAULT_RETRY_COUNT;
>  
>  module_param(rds_ib_mr_1m_pool_size, int, 0444);
> diff --git a/net/rds/ib_mr.h b/net/rds/ib_mr.h
> index 24c086d..5d6e98a 100644
> --- a/net/rds/ib_mr.h
> +++ b/net/rds/ib_mr.h
> @@ -107,8 +107,6 @@ struct rds_ib_mr_pool {
>  };
>  
>  extern struct workqueue_struct *rds_ib_mr_wq;
> -extern unsigned int rds_ib_mr_1m_pool_size;
> -extern unsigned int rds_ib_mr_8k_pool_size;
>  extern bool prefer_frmr;

Reviewed-by: Yuval Shaia <yuval.shaia@...cle.com>

>  
>  struct rds_ib_mr_pool *rds_ib_create_mr_pool(struct rds_ib_device *rds_dev,
> -- 
> 2.7.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html