netdev - Re: [Patch net v3] ipv6: check for ip6_null_entry in __ip6_del_rt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpXz6QnhLYFFD=-iE_yfgUZ13_o+u_VMffWgr0hxE_fZXA@mail.gmail.com>
Date:   Mon, 27 Feb 2017 16:40:24 -0800
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     David Ahern <dsa@...ulusnetworks.com>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Andrey Konovalov <andreyknvl@...gle.com>,
        Eric Dumazet <eric.dumazet@...il.com>
Subject: Re: [Patch net v3] ipv6: check for ip6_null_entry in __ip6_del_rt_siblings()

On Mon, Feb 27, 2017 at 4:14 PM, David Ahern <dsa@...ulusnetworks.com> wrote:
> On 2/27/17 4:07 PM, Cong Wang wrote:
>> Andrey reported a NULL pointer deref bug in ipv6_route_ioctl()
>> -> ip6_route_del() -> __ip6_del_rt_siblings() code path. This is
>> because ip6_null_entry is returned in this path since ip6_null_entry
>> is kinda default for a ipv6 route table root node. Quote from
>
>
> Missed this earlier. The issue here is an attempt to delete the NULL
> route, not that the null_entry is being returned as happens during a
> route lookup. This will also hit the bug:
>     ip -6 ro del ::/0

By "returned" I mean it is in the fn->leaf list.