netdev - Re: [PATCH net] bridge: Fix error path in nbp_vlan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170301191435.GD2365@nanopsycho>
Date:   Wed, 1 Mar 2017 20:14:35 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Yotam Gigi <yotamg@...lanox.com>
Cc:     stephen@...workplumber.org, davem@...emloft.net,
        bridge@...ts.linux-foundation.org, netdev@...r.kernel.org,
        idosch@...lanox.com, eladr@...lanox.com, jiri@...lanox.com,
        roopa@...ulusnetworks.com
Subject: Re: [PATCH net] bridge: Fix error path in nbp_vlan_init

Wed, Mar 01, 2017 at 03:50:45PM CET, yotamg@...lanox.com wrote:
>Fix error path order in nbp_vlan_init, so if switchdev_port_attr_set
>call failes, the vlan_hash wouldn't be destroyed before inited.
>
>Fixes: efa5356b0d97 ("bridge: per vlan dst_metadata netlink support")
>CC: Roopa Prabhu <roopa@...ulusnetworks.com>
>Signed-off-by: Yotam Gigi <yotamg@...lanox.com>

Reviewed-by: Jiri Pirko <jiri@...lanox.com>