netdev - Re: usb/net/hso: WARNING: ungligned urb->setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 1 Mar 2017 12:54:37 +0200
From:   Baruch Siach <baruch@...s.co.il>
To:     Stefan Wahren <stefan.wahren@...e.com>
Cc:     John Youn <johnyoun@...opsys.com>, netdev@...r.kernel.org,
        linux-usb@...r.kernel.org, Olivier Sobrie <olivier@...rie.be>,
        linux-rpi-kernel@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: usb/net/hso: WARNING: ungligned urb->setup_dma

Hi Stefan,

On Tue, Feb 28, 2017 at 07:32:09PM +0100, Stefan Wahren wrote: 
> > Baruch Siach <baruch@...s.co.il> hat am 28. Februar 2017 um 19:07 geschrieben:
> > On Tue, Feb 28, 2017 at 05:21:18PM +0100, Stefan Wahren wrote:
> > > Am 28.02.2017 um 13:01 schrieb Baruch Siach:
> > > > On Tue, Feb 28, 2017 at 10:28:10AM +0200, Baruch Siach wrote:
> > > > > I'm hitting this warning consistently on my Raspberry Pi 3 running 
> > > > > kernel
> > > > > v4.10.1 with some unrelated device tree changes, and a debug print (below).
> > > > > The device identifies as "GlobeTrotter HSDPA Modem", VID: 0af0, PID: 6971.
> > > > > The warning triggers consistently on first write access to /dev/ttyHS0 that
> > > > > ModemManager attempts. The first line in the log is my debug print.
> > > > I tested the same hardware successfully on an i.MX6 CuBox-i (ARM32) using the
> > > > same kernel version (4.10.1), and on an x86_64 PC (4.9). So this seems to be
> > > > platform specific. I don't have any other ARM64 machine at the moment, though.
> > > 
> > > those platforms usually doesn't use the dwc2 USB host controller. So it
> > > should be tested with another dwc2 platform.
> > 
> > The code that initializes setup_dma is not under drivers/usb/dwc2/. Though the 
> > problem looks like memory corruption, so its cause might be anywhere.
> 
> only a suspicion, but could you please try this patch [1]?
> 
> [1] - https://patchwork.kernel.org/patch/9166771/

It doesn't change anything.

My guess is that source of the issue is memory corruption that just happens to 
corrupt also the setup_dma field of struct urb. In other words, it has nothing 
to do with DMA, IMO.

Thanks,
baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@...s.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -