netdev - Re: [PATCH] net: usb: asix_devices: fix missing return code check on call to asix_write_medium

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170301.125226.289007568565020464.davem@davemloft.net>
Date:   Wed, 01 Mar 2017 12:52:26 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     colin.king@...onical.com
Cc:     robert.foss@...labora.com, grundler@...gle.com, allan@...x.com.tw,
        vpalatin@...omium.org, jarod@...hat.com, peter.chen@....com,
        linux-usb@...r.kernel.org, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: usb: asix_devices: fix missing return code check
 on call to asix_write_medium_mode

From: Colin King <colin.king@...onical.com>
Date: Tue, 28 Feb 2017 11:58:22 +0000

> From: Colin Ian King <colin.king@...onical.com>
> 
> The call to asix_write_medium_mode is not updating the return code ret
> and yet ret is being checked for an error. Fix this by assigning ret to
> the return code from the call asix_write_medium_mode.
> 
> Detected by CoverityScan, CID#1357148 ("Logically Dead Code")
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Applied.