netdev - Re: [PATCH-v4-RESEND 1/4] vsock: track pkt owner vsock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170302.131303.703202861280343181.davem@davemloft.net>
Date:   Thu, 02 Mar 2017 13:13:03 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     bergwolf@...il.com
Cc:     netdev@...r.kernel.org, virtualization@...ts.linux-foundation.org,
        kvm@...r.kernel.org, stefanha@...hat.com, jhansen@...are.com
Subject: Re: [PATCH-v4-RESEND 1/4] vsock: track pkt owner vsock

From: Peng Tao <bergwolf@...il.com>
Date: Wed,  1 Mar 2017 11:56:24 +0800

> So that we can cancel a queued pkt later if necessary.
> 
> Reviewed-by: Stefan Hajnoczi <stefanha@...hat.com>
> Signed-off-by: Peng Tao <bergwolf@...il.com>
> ---
>  include/linux/virtio_vsock.h            | 2 ++
>  net/vmw_vsock/virtio_transport_common.c | 7 +++++++
>  2 files changed, 9 insertions(+)
> 
> diff --git a/include/linux/virtio_vsock.h b/include/linux/virtio_vsock.h
> index 9638bfe..193ad3a 100644
> --- a/include/linux/virtio_vsock.h
> +++ b/include/linux/virtio_vsock.h
> @@ -48,6 +48,7 @@ struct virtio_vsock_pkt {
>  	struct virtio_vsock_hdr	hdr;
>  	struct work_struct work;
>  	struct list_head list;
> +	void *cancel_token; /* only used for cancellation */

The type here is fixed, you only store vhost_sock object pointers
here, so don't use "void *" please.