netdev - Re: [PATCH net] ipv6: orphan skbs in reassembly unit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170301.205847.286271242445976841.davem@davemloft.net>
Date:   Wed, 01 Mar 2017 20:58:47 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     eric.dumazet@...il.com
Cc:     netdev@...r.kernel.org, andreyknvl@...gle.com
Subject: Re: [PATCH net] ipv6: orphan skbs in reassembly unit

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Wed, 01 Mar 2017 14:45:06 -0800

> From: Eric Dumazet <edumazet@...gle.com>
> 
> Andrey reported a use-after-free in IPv6 stack.
> 
> Issue here is that we free the socket while it still has skb
> in TX path and in some queues.
> 
> It happens here because IPv6 reassembly unit messes skb->truesize,
> breaking skb_set_owner_w() badly.
> 
> We fixed a similar issue for IPV4 in commit 8282f27449bf ("inet: frag:
> Always orphan skbs inside ip_defrag()")
 ...
> Reported-by: Andrey Konovalov <andreyknvl@...gle.com>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied and queued up for -stable.

Thanks.