netdev - RE: [PATCH net] xen-netback: Use GFP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <92c0d11454744be4879fd3f4870480be@AMSPEX02CL03.citrite.net>
Date:   Thu, 2 Mar 2017 10:51:52 +0000
From:   Paul Durrant <Paul.Durrant@...rix.com>
To:     Anoob Soman <anoob.soman@...rix.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "xen-devel@...ts.xenproject.org" <xen-devel@...ts.xenproject.org>
CC:     Wei Liu <wei.liu2@...rix.com>, Anoob Soman <anoob.soman@...rix.com>
Subject: RE: [PATCH net] xen-netback: Use GFP_ATOMIC to allocate hash

> -----Original Message-----
> From: Anoob Soman [mailto:anoob.soman@...rix.com]
> Sent: 02 March 2017 10:50
> To: netdev@...r.kernel.org; xen-devel@...ts.xenproject.org
> Cc: Paul Durrant <Paul.Durrant@...rix.com>; Wei Liu <wei.liu2@...rix.com>;
> Anoob Soman <anoob.soman@...rix.com>
> Subject: [PATCH net] xen-netback: Use GFP_ATOMIC to allocate hash
> 
> Allocation of new_hash, inside xenvif_new_hash(), always happen
> in softirq context, so use GFP_ATOMIC instead of GFP_KERNEL for new
> hash allocation.
> 
> Signed-off-by: Anoob Soman <anoob.soman@...rix.com>

Acked-by: Paul Durrant <paul.durrant@...rix.com>

> ---
>  drivers/net/xen-netback/hash.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/xen-netback/hash.c b/drivers/net/xen-
> netback/hash.c
> index e8c5ddd..3c4c58b 100644
> --- a/drivers/net/xen-netback/hash.c
> +++ b/drivers/net/xen-netback/hash.c
> @@ -39,7 +39,7 @@ static void xenvif_add_hash(struct xenvif *vif, const u8
> *tag,
>  	unsigned long flags;
>  	bool found;
> 
> -	new = kmalloc(sizeof(*entry), GFP_KERNEL);
> +	new = kmalloc(sizeof(*entry), GFP_ATOMIC);
>  	if (!new)
>  		return;
> 
> --
> 2.7.4