netdev - Re: [PATCH] net: smsc: smc91x: use new api ethtool_{get|set}_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 4 Mar 2017 10:20:17 +0000
From:   Russell King - ARM Linux <linux@...linux.org.uk>
To:     Philippe Reynes <tremyfr@...il.com>
Cc:     nico@...xnic.net, davem@...emloft.net, robert.jarzmik@...e.fr,
        mugunthanvnm@...com, jarod@...hat.com,
        felipe.balbi@...ux.intel.com, fw@...len.de, jeremy.linton@....com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: smsc: smc91x: use new api
 ethtool_{get|set}_link_ksettings

On Sat, Mar 04, 2017 at 11:11:32AM +0100, Philippe Reynes wrote:
>  
>  //		lp->port = cmd->port;

Hi,

Review looks good.  However, please also update the above comment as
well.

Thanks.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.