lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Mon, 6 Mar 2017 18:06:36 +0100
From:   Pablo Neira Ayuso <>
To:     Colin King <>
Cc:     Jozsef Kadlecsik <>,
        "David S . Miller" <>,
        Alexey Kuznetsov <>,
        James Morris <>,
        Hideaki YOSHIFUJI <>,
        Patrick McHardy <>,,,,,
Subject: Re: [PATCH] netfilter: remove redundant check on ret being non-zero

On Tue, Feb 28, 2017 at 11:31:15AM +0000, Colin King wrote:
> From: Colin Ian King <>
> ret is initialized to zero and if it is set to non-zero in the
> xt_entry_foreach loop then we exit via the out_free label. Hence
> the check for ret being non-zero is redundant and can be removed.
> Detected by CoverityScan, CID#1357132 ("Logically Dead Code")

Applied, thanks.

Powered by blists - more mailing lists