netdev - Re: [PATCH net v2] net: phy: Do not perform software reset for Generic PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170305.175811.174357146943827777.davem@davemloft.net>
Date:   Sun, 05 Mar 2017 17:58:11 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     f.fainelli@...il.com
Cc:     netdev@...r.kernel.org, andrew@...n.ch, nbd@....name,
        john@...ozen.org, cphealy@...il.com
Subject: Re: [PATCH net v2] net: phy: Do not perform software reset for
 Generic PHY

From: Florian Fainelli <f.fainelli@...il.com>
Date: Sun,  5 Mar 2017 12:34:49 -0800

> The Generic PHY driver is a catch-all PHY driver and it should preserve
> whatever prior initialization has been done by boot loader or firmware
> agents. For specific PHY device configuration it is expected that a
> specialized PHY driver would take over that role.
> 
> Resetting the generic PHY was a bad idea that has lead to several
> complaints and downstream workarounds e.g: in OpenWrt/LEDE so restore
> the behavior prior to 87aa9f9c61ad ("net: phy: consolidate PHY
> reset in phy_init_hw()").
> 
> Reported-by: Felix Fietkau <nbd@....name>
> Fixes: 87aa9f9c61ad ("net: phy: consolidate PHY reset in phy_init_hw()")
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>

Applied, thanks Florian.