netdev - Re: [PATCH net-next RFC 3/4] vhost: interrupt coalescing support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51a3fba2-a789-7bcf-946d-577220865709@redhat.com>
Date:   Mon, 6 Mar 2017 17:28:07 +0800
From:   Jason Wang <jasowang@...hat.com>
To:     Willem de Bruijn <willemdebruijn.kernel@...il.com>,
        netdev@...r.kernel.org
Cc:     mst@...hat.com, Willem de Bruijn <willemb@...gle.com>
Subject: Re: [PATCH net-next RFC 3/4] vhost: interrupt coalescing support



On 2017年03月03日 22:39, Willem de Bruijn wrote:
> +void vhost_signal(struct vhost_dev *dev, struct vhost_virtqueue *vq);
> +static enum hrtimer_restart vhost_coalesce_timer(struct hrtimer *timer)
> +{
> +	struct vhost_virtqueue *vq =
> +		container_of(timer, struct vhost_virtqueue, ctimer);
> +
> +	if (mutex_trylock(&vq->mutex)) {
> +		vq->coalesce_frames = vq->max_coalesce_frames;
> +		vhost_signal(vq->dev, vq);
> +		mutex_unlock(&vq->mutex);
> +	}
> +
> +	/* TODO: restart if lock failed and not held by handle_tx */
> +	return HRTIMER_NORESTART;
> +}
> +

Then we may lose an interrupt forever if no new tx request? I believe we 
need e.g vhost_poll_queue() here.

Thanks