netdev - Re: 4.11-rc1 regression: e1000e "BUG at drivers/pci/msi.c" on unplugged suspend+resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8760jmipdn.fsf@miraculix.mork.no>
Date:   Mon, 06 Mar 2017 13:03:16 +0100
From:   Bjørn Mork <bjorn@...k.no>
To:     intel-wired-lan@...ts.osuosl.org
Cc:     netdev@...r.kernel.org, khalidm <khalidm@...co.com>,
        David Singleton <davsingl@...co.com>,
        Aaron Brown <aaron.f.brown@...el.com>,
        Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Subject: Re: 4.11-rc1 regression: e1000e "BUG at drivers/pci/msi.c" on unplugged suspend+resume

Bjørn Mork <bjorn@...k.no> writes:

> This is new with v4.11-rc1, so I strongly suspect commit 7e54d9d063fa
> ("e1000e: driver trying to free already-free irq"), which looks more
> than suspicious in this context.  Haven't had time to test a revert
> yet.  Just wanted to give an advance warning in case this isn't known.

Now tested.  I can confirm that reverting commit 7e54d9d063fa ("e1000e:
driver trying to free already-free irq") fixes the issue.

Further testing also shows that "netif running" is irrelevant.  The BUG
happens consistently on revery system resume, regardless of the e1000e
link state.  Which sort of indicates that this change to the driver's
freeze callback wasn't tested with system suspend.  Which seems.... odd?

Well, whatever.  Please revert commit 7e54d9d063fa.

Bjørn