netdev - Re: [PATCH net] dccp: fix use-after-free in dccp_feat_activate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1488782529.9415.371.camel@edumazet-glaptop3.roam.corp.google.com>
Date:   Sun, 05 Mar 2017 22:42:09 -0800
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Cong Wang <xiyou.wangcong@...il.com>
Cc:     Dmitry Vyukov <dvyukov@...gle.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Gerrit Renker <gerrit@....abdn.ac.uk>,
        netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net] dccp: fix use-after-free in
 dccp_feat_activate_values

On Sun, 2017-03-05 at 21:38 -0800, Cong Wang wrote:

> Do you really want to disable BH again here?
> 
> dccp_check_req() should be always called on RX path where BH
> is already disabled and BH can't be disabled twice?

What makes you think BH can't be disabled twice ?

Look, I prefer being cautious here, no need to get another DCCP bug
report later.