lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <BL2PR07MB230674114D97A4A4EBB78F158D2F0@BL2PR07MB2306.namprd07.prod.outlook.com> Date: Tue, 7 Mar 2017 15:54:35 +0000 From: "Mintz, Yuval" <Yuval.Mintz@...ium.com> To: Michal Schmidt <mschmidt@...hat.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org> CC: "Elior, Ariel" <Ariel.Elior@...ium.com> Subject: RE: [PATCH net 3/7 v2] bnx2x: fix possible overrun of VFPF multicast addresses array > It is too late to check for the limit of the number of VF multicast addresses > after they have already been copied to the req->multicast[] array, possibly > overflowing it. > > Do the check before copying. > > Checking early also avoids having to (and forgetting to) unlock vf2pf_mutex. > > While we're looking at the error paths in the function, also return an error > code from it when the PF responds with an error. Even though the caller > ignores it. > > v2: Move the check before bnx2x_vfpf_prep() as suggested by Yuval. > > Signed-off-by: Michal Schmidt <mschmidt@...hat.com> Acked-by: Yuval Mintz <Yuval.Mintz@...ium.com
Powered by blists - more mailing lists