netdev - Re: [PATCH] arp: Race condition in gratuitous ARP reception handling.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170307.134338.1195186271110286952.davem@davemloft.net>
Date:   Tue, 07 Mar 2017 13:43:38 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     tomasz.dzieciol@...ia.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH] arp: Race condition in gratuitous ARP reception
 handling.

From: <tomasz.dzieciol@...ia.com>
Date: Thu, 2 Mar 2017 14:59:47 +0100

> @@ -836,19 +843,30 @@ static int arp_process(struct net *net, struct sock *sk, struct sk_buff *skb)
>  	n = __neigh_lookup(&arp_tbl, &sip, dev, 0);
>  
>  	if (IN_DEV_ARP_ACCEPT(in_dev)) {
> -		unsigned int addr_type = inet_addr_type_dev_table(net, dev, sip);
> +		unsigned int addr_type = inet_addr_type_dev_table(net,
> +								  dev, sip);

Please don't mix coding style changes with real modifications.

> +	} else if (n) {
> +		unsigned int addr_type = inet_addr_type_dev_table(net,
> +								  dev, sip);

Thanks.