netdev - Re: [PATCH net] dccp: fix use-after-free in dccp_feat_activate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170307.141603.1834989423312592126.davem@davemloft.net>
Date:   Tue, 07 Mar 2017 14:16:03 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     eric.dumazet@...il.com
Cc:     dvyukov@...gle.com, edumazet@...gle.com, gerrit@....abdn.ac.uk,
        netdev@...r.kernel.org
Subject: Re: [PATCH net] dccp: fix use-after-free in
 dccp_feat_activate_values

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Sun, 05 Mar 2017 10:52:16 -0800

> From: Eric Dumazet <edumazet@...gle.com>
> 
> Dmitry reported crashes in DCCP stack [1]
> 
> Problem here is that when I got rid of listener spinlock, I missed the
> fact that DCCP stores a complex state in struct dccp_request_sock,
> while TCP does not.
> 
> Since multiple cpus could access it at the same time, we need to add
> protection.
 ...
> Fixes: 079096f103fa ("tcp/dccp: install syn_recv requests into ehash table")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: Dmitry Vyukov <dvyukov@...gle.com>
> Tested-by: Dmitry Vyukov <dvyukov@...gle.com>

Applied and queued up for -stable.