netdev - Re: [PATCH net 0/3] rds: tcp: fix various rds-tcp issues during netns create/delete sequences

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACT4Y+aKp6LPUSR4yivWKMFjC1QeC7qbqiQ7hFCwj+RhDt5Msw@mail.gmail.com>
Date:   Tue, 7 Mar 2017 09:28:15 +0100
From:   Dmitry Vyukov <dvyukov@...gle.com>
To:     "santosh.shilimkar@...cle.com" <santosh.shilimkar@...cle.com>
Cc:     Sowmini Varadhan <sowmini.varadhan@...cle.com>,
        David Miller <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        syzkaller <syzkaller@...glegroups.com>, rds-devel@....oracle.com
Subject: Re: [PATCH net 0/3] rds: tcp: fix various rds-tcp issues during netns
 create/delete sequences

On Tue, Mar 7, 2017 at 2:04 AM, santosh.shilimkar@...cle.com
<santosh.shilimkar@...cle.com> wrote:
> On 3/4/17 8:57 AM, Sowmini Varadhan wrote:
>>
>> Dmitry Vyukov reported some syszkaller panics during netns deletion.
>>
>> While I have not been able to reproduce those exact panics, my attempts
>> to do so uncovered a few other problems, which are fixed patch 2 and
>> patch 3 of this patch series. In addition, as mentioned in,
>>  https://www.spinics.net/lists/netdev/msg422997.html
>> code-inspection points that the rds_connection needs to take an explicit
>> refcnt on the struct net so that it is held down until all cleanup is
>> completed for netns removal, and this is fixed by patch1.
>>
> Hopefully Dmitry can try the series and see if it fixes the issue(s).
> The fixes looks good to me.
>
> FWIW, Acked-by: Santosh Shilimkar <santosh.shilimkar@...cle.com>


I've applied the patches for testing. I've seen the reported crashes
only few times, so it won't provide a good testing. But at least it
can detect any regressions.