netdev - Re: [4.9.13] use after free in ipv4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMVG2st2i2EHP+Qqzj-o4Bchhy2ptNiQJUKPHXX=dmnV3JWpjQ@mail.gmail.com>
Date:   Tue, 7 Mar 2017 20:29:40 +0800
From:   Daniel J Blueman <daniel@...ra.org>
To:     Eric Dumazet <eric.dumazet@...il.com>
Cc:     Netdev <netdev@...r.kernel.org>,
        David Miller <davem@...emloft.net>,
        Stephen Hemminger <shemminger@...ux-foundation.org>
Subject: Re: [4.9.13] use after free in ipv4_mtu

On 7 March 2017 at 00:20, Eric Dumazet <eric.dumazet@...il.com> wrote:
> On Mon, 2017-03-06 at 05:45 -0800, Eric Dumazet wrote:
>> On Mon, 2017-03-06 at 14:33 +0800, Daniel J Blueman wrote:
>
>> > I do change the network queueing discipline and related at runtime [1]
>> > which may be triggering this, though I did think I saw the KASAN
>> > report only after resuming from suspend. rf(un)kill and other tweaking
>> > may have been involved too.
>> >
>> > Thanks,
>> >   Dan
>> >
>> > [1] /etc/sysctl.d/90-tcp.conf
>> >
>> > net.core.default_qdisc = fq_codel
>> > net.ipv4.tcp_congestion_control = bbr
>> > net.ipv4.tcp_slow_start_after_idle = 0
>> > net.ipv4.tcp_ecn = 1
>
> BTW, fq_codel is not suitable for BBR.
>
> Only fq contains the needed pacing for BBR.

Good tip, thanks Eric!
-- 
Daniel J Blueman