netdev - Re: [PATCH net-next] net: ipv6: Add early demux handler for UDP unicast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8b6968063320eb8ddc654f79d3461f21@codeaurora.org>
Date:   Wed, 08 Mar 2017 12:11:43 -0700
From:   Subash Abhinov Kasiviswanathan <subashab@...eaurora.org>
To:     Eric Dumazet <eric.dumazet@...il.com>
Cc:     netdev@...r.kernel.org, netdev-owner@...r.kernel.org
Subject: Re: [PATCH net-next] net: ipv6: Add early demux handler for UDP
 unicast

On 2017-03-08 11:40, Eric Dumazet wrote:
> Well, this 'optimization' actually hurts when UDP sockets are not
> connected, since this adds an extra cache line miss per incoming 
> packet.
> 
> (DNS servers for example)

Hi Eric

Thanks for your comments. Would it be preferable to disable early demux 
for the
servers with large unconnected workloads in that case?

> 
>> 
>> Signed-off-by: Subash Abhinov Kasiviswanathan 
>> <subashab@...eaurora.org>
>> ---
> 
>> +
>> +	if (dst)
>> +		dst = dst_check(dst, 0);
> 
> 
> IPv6 uses a cookie to validate dst, not 0.

I'll update this and send v2.

--
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a 
Linux Foundation Collaborative Project