netdev - Re: [PATCH net-next 1/1] net: rmnet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <567a5c64abe80b82d58ef8c94f249848@codeaurora.org>
Date:   Wed, 08 Mar 2017 14:25:19 -0700
From:   Subash Abhinov Kasiviswanathan <subashab@...eaurora.org>
To:     David Miller <davem@...emloft.net>
Cc:     netdev@...r.kernel.org, fengguang.wu@...el.com,
        netdev-owner@...r.kernel.org
Subject: Re: [PATCH net-next 1/1] net: rmnet_data: Initial implementation

> Inside the kernel you should use "u32", "u16", "u8", etc. for purely
> internal things, and for datastructures exported to userspace you
> should use "__u32", "__u16", "__u8".
> 
> Furthermore, if the members have specific endianness you should
> properly use the "__le32", "__le16", "__be32", "__be16" etc. types.
> 
> 
> Please use netlink for device instantiation and configuration
> rather than ioctls.

Hi David

Thanks for reviewing. I'll post v2 with these changes.

--
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a 
Linux Foundation Collaborative Project