netdev - Re: [PATCH v4 net-next 10/13] mlx4: do not access rx_desc from mlx4_en_process_rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c64c3086-baab-3f1b-266a-4a4533e0c271@mellanox.com>
Date:   Thu, 9 Mar 2017 15:56:54 +0200
From:   Tariq Toukan <tariqt@...lanox.com>
To:     Eric Dumazet <edumazet@...gle.com>,
        "David S . Miller" <davem@...emloft.net>
CC:     netdev <netdev@...r.kernel.org>,
        Tariq Toukan <tariqt@...lanox.com>,
        Saeed Mahameed <saeedm@...lanox.com>,
        Willem de Bruijn <willemb@...gle.com>,
        Jesper Dangaard Brouer <brouer@...hat.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Eric Dumazet <eric.dumazet@...il.com>
Subject: Re: [PATCH v4 net-next 10/13] mlx4: do not access rx_desc from
 mlx4_en_process_rx_cq()



On 08/03/2017 6:17 PM, Eric Dumazet wrote:
> Instead of fetching dma address from rx_desc->data[0].addr,
> prefer using frags[0].dma + frags[0].page_offset to avoid
> a potential cache line miss.
>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> ---
>  drivers/net/ethernet/mellanox/mlx4/en_rx.c | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
>
Acked-by: Tariq Toukan <tariqt@...lanox.com>

Thanks.