netdev - Re: [PATCH v4 net-next 01/13] mlx4: dma_dir is a mlx4_en

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <030558e2-8267-f231-ff49-bc276fe4b11b@mellanox.com>
Date:   Thu, 9 Mar 2017 15:52:56 +0200
From:   Tariq Toukan <tariqt@...lanox.com>
To:     Eric Dumazet <edumazet@...gle.com>,
        "David S . Miller" <davem@...emloft.net>
CC:     netdev <netdev@...r.kernel.org>,
        Tariq Toukan <tariqt@...lanox.com>,
        "Saeed Mahameed" <saeedm@...lanox.com>,
        Willem de Bruijn <willemb@...gle.com>,
        "Jesper Dangaard Brouer" <brouer@...hat.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Eric Dumazet <eric.dumazet@...il.com>
Subject: Re: [PATCH v4 net-next 01/13] mlx4: dma_dir is a mlx4_en_priv
 attribute



On 08/03/2017 6:17 PM, Eric Dumazet wrote:
> No need to duplicate it for all queues and frags.
>
> num_frags & log_rx_info become u8 to save space.
> u8 accesses are a bit faster than u16 anyway.
>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> ---
>  drivers/net/ethernet/mellanox/mlx4/en_rx.c   | 16 ++++++++--------
>  drivers/net/ethernet/mellanox/mlx4/en_tx.c   |  2 +-
>  drivers/net/ethernet/mellanox/mlx4/mlx4_en.h |  6 +++---
>  3 files changed, 12 insertions(+), 12 deletions(-)
>

Acked-by: Tariq Toukan <tariqt@...lanox.com>

Thanks.