netdev - Re: [PATCH v3 net-next] liquidio: improve UDP TX performance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170309.130835.1755242052162375234.davem@davemloft.net>
Date:   Thu, 09 Mar 2017 13:08:35 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     felix.manlunas@...ium.com
Cc:     netdev@...r.kernel.org, raghu.vatsavayi@...ium.com,
        derek.chickles@...ium.com, satananda.burla@...ium.com,
        veerasenareddy.burru@...ium.com
Subject: Re: [PATCH v3 net-next] liquidio: improve UDP TX performance

From: Felix Manlunas <felix.manlunas@...ium.com>
Date: Mon, 6 Mar 2017 18:45:59 -0800

> Improve UDP TX performance by:
> * reducing the ring size from 2K to 512
> * replacing the numerous streaming DMA allocations for info buffers and
>   gather lists with one large consistent DMA allocation per ring

I applied this, because one should always use consistent mappings for
descriptor arrays and things like this, however I am confused about
this:

> Also, finding an empty entry (in rbtree of device domain's iova mapping in
> kernel) during Tx path becomes a bottleneck every so often; the loop to
> find the empty entry goes through over 40K iterations;

A properly balanced tree should not require 40K iterations for a search.