netdev - Re: [PATCH] uapi: fix linux/packet_diag.h userspace compilation error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170309.132306.2135023022720335742.davem@davemloft.net>
Date:   Thu, 09 Mar 2017 13:23:06 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     ldv@...linux.org
Cc:     xemul@...tuozzo.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] uapi: fix linux/packet_diag.h userspace compilation
 error

From: "Dmitry V. Levin" <ldv@...linux.org>
Date: Tue, 7 Mar 2017 23:50:50 +0300

> Replace MAX_ADDR_LEN with its numeric value to fix the following
> linux/packet_diag.h userspace compilation error:
> 
> /usr/include/linux/packet_diag.h:67:17: error: 'MAX_ADDR_LEN' undeclared here (not in a function)
>   __u8 pdmc_addr[MAX_ADDR_LEN];
> 
> This is not the first case in the UAPI where the numeric value
> of MAX_ADDR_LEN is used instead of symbolic one, uapi/linux/if_link.h
> already does the same:
> 
> $ grep MAX_ADDR_LEN include/uapi/linux/if_link.h 
> 	__u8 mac[32]; /* MAX_ADDR_LEN */
> 
> There are no UAPI headers besides these two that use MAX_ADDR_LEN.
> 
> Signed-off-by: Dmitry V. Levin <ldv@...linux.org>
> Acked-by: Pavel Emelyanov <xemul@...tuozzo.com>

Applied and queued up for -stable.