netdev - Re: [PATCH net v3] xen-netback: fix race condition on XenBus disconnect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <201703100713.sZb9Gsru%fengguang.wu@intel.com>
Date:   Fri, 10 Mar 2017 07:36:20 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Igor Druzhinin <igor.druzhinin@...rix.com>
Cc:     kbuild-all@...org, netdev@...r.kernel.org,
        xen-devel@...ts.xenproject.org, paul.durrant@...rix.com,
        jgross@...e.com, wei.liu2@...rix.com,
        Igor Druzhinin <igor.druzhinin@...rix.com>
Subject: Re: [PATCH net v3] xen-netback: fix race condition on XenBus
 disconnect

Hi Igor,

[auto build test WARNING on net/master]

url:    https://github.com/0day-ci/linux/commits/Igor-Druzhinin/xen-netback-fix-race-condition-on-XenBus-disconnect/20170310-055447
reproduce:
        # apt-get install sparse
        make ARCH=x86_64 allmodconfig
        make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

   include/linux/compiler.h:264:8: sparse: attribute 'no_sanitize_address': unknown attribute
>> drivers/net/xen-netback/interface.c:178:22: sparse: incompatible types in comparison expression (different address spaces)
   drivers/net/xen-netback/interface.c:237:22: sparse: incompatible types in comparison expression (different address spaces)
   drivers/net/xen-netback/interface.c:389:22: sparse: incompatible types in comparison expression (different address spaces)

vim +178 drivers/net/xen-netback/interface.c

   162	}
   163	
   164	static int xenvif_start_xmit(struct sk_buff *skb, struct net_device *dev)
   165	{
   166		struct xenvif *vif = netdev_priv(dev);
   167		struct xenvif_queue *queue = NULL;
   168		unsigned int num_queues;
   169		u16 index;
   170		struct xenvif_rx_cb *cb;
   171	
   172		BUG_ON(skb->dev != dev);
   173	
   174		/* Drop the packet if queues are not set up.
   175		 * This handler should be called inside an RCU read section
   176		 * so we don't need to enter it here explicitly.
   177		 */
 > 178		num_queues = rcu_dereference(vif)->num_queues;
   179		if (num_queues < 1)
   180			goto drop;
   181	
   182		/* Obtain the queue to be used to transmit this packet */
   183		index = skb_get_queue_mapping(skb);
   184		if (index >= num_queues) {
   185			pr_warn_ratelimited("Invalid queue %hu for packet on interface %s\n.",
   186					    index, vif->dev->name);

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation