netdev - Re: [PATCH] net: ibm: emac: fix regression caused by emac_dt_phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170308.221828.111180540611215509.davem@davemloft.net>
Date:   Wed, 08 Mar 2017 22:18:28 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     chunkeey@...glemail.com
Cc:     netdev@...r.kernel.org, runaway@...dw.ms
Subject: Re: [PATCH] net: ibm: emac: fix regression caused by
 emac_dt_phy_probe()

From: Christian Lamparter <chunkeey@...glemail.com>
Date: Mon,  6 Mar 2017 14:34:27 +0100

> Julian Margetson reported a panic on his SAM460EX with Kernel 4.11-rc1:
 ...
> The problem is caused by emac_dt_phy_probe() returing success (0)
> for existing device-trees configurations that do not specify a
> "phy-handle" property. This caused the code to skip the existing
> phy probe and setup. Which led to essential phy related
> data-structures being uninitialized.
> 
> This patch also removes the unused variable in emac_dt_phy_connect().
> 
> Fixes: a577ca6badb5261d ("net: emac: add support for device-tree based PHY discovery and setup")
> Reported-by: Julian Margetson <runaway@...dw.ms>
> Signed-off-by: Christian Lamparter <chunkeey@...glemail.com>

Applied, thanks.