netdev - Re: [PATCH] Fix bug while selecting sysfs node size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 8 Mar 2017 17:50:25 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Lev Urusov <urusov@...nch.ru>, netdev@...r.kernel.org
Subject: Re: [PATCH] Fix bug while selecting sysfs node size

On 03/08/2017 05:43 PM, Lev Urusov wrote:
> From: Lev Urusov <urusov@...nch.ru>
> 
> The driver will not be able to take into account the correct number
> of device SPI registers if it is not equal to 128.

You would want to fix a couple of things with this patchset, since you
are fixing a bug, can you provide the proper Fixes: tag information that
indicates which commit you are fixing (so it can be backported to stable
kernels), and the subject should be something like:

net: phy: ks8995: Fix bug while selecting sysfs node size

Thanks!

> 
> Signed-off-by: Lev Urusov <urusov@...nch.ru>
> ---
>  drivers/net/phy/spi_ks8995.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/phy/spi_ks8995.c b/drivers/net/phy/spi_ks8995.c
> index 93ffedf..f084725 100644
> --- a/drivers/net/phy/spi_ks8995.c
> +++ b/drivers/net/phy/spi_ks8995.c
> @@ -491,8 +491,8 @@ static int ks8995_probe(struct spi_device *spi)
>  	if (err)
>  		return err;
>  
> -	ks->regs_attr.size = ks->chip->regs_size;
>  	memcpy(&ks->regs_attr, &ks8995_registers_attr, sizeof(ks->regs_attr));
> +	ks->regs_attr.size = ks->chip->regs_size;
>  
>  	err = ks8995_reset(ks);
>  	if (err)
> 


-- 
Florian