netdev - Re: [PATCH iproute2 master] bpf: test for valid type in bpf_get_work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170308175747.2d235bd5@xeon-e3>
Date:   Wed, 8 Mar 2017 17:57:47 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Daniel Borkmann <daniel@...earbox.net>
Cc:     alexei.starovoitov@...il.com, janerik@...iger.net,
        netdev@...r.kernel.org
Subject: Re: [PATCH iproute2 master] bpf: test for valid type in
 bpf_get_work_dir

On Mon,  6 Mar 2017 13:06:00 +0100
Daniel Borkmann <daniel@...earbox.net> wrote:

> Jan-Erik reported an assertion in bpf_prog_to_subdir() failed where
> type was BPF_PROG_TYPE_UNSPEC, which is only used in bpf_init_env()
> to auto-mount and cache the bpf fs mount point.
> 
> Therefore, make sure when bpf_init_env() is called multiple times
> (f.e. eBPF classifier with eBPF action attached) and bpf_mnt_cached
> is set already that the type is also valid. In bpf_init_env(), we're
> only interested in the mount point and not a type-specific subdir.
> 
> Fixes: e42256699cac ("bpf: make tc's bpf loader generic and move into lib")
> Reported-by: Jan-Erik Rediger <janerik@...iger.net>
> Signed-off-by: Daniel Borkmann <daniel@...earbox.net>

Applied