netdev - Re: [PATCH net] amd-xgbe: Enable IRQs only if napi_complete

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ceb2935c-deac-1bcc-c833-ac2944487c98@amd.com>
Date:   Fri, 10 Mar 2017 08:19:37 -0600
From:   Tom Lendacky <thomas.lendacky@....com>
To:     David Miller <davem@...emloft.net>
CC:     <netdev@...r.kernel.org>, <jeremy.linton@....com>
Subject: Re: [PATCH net] amd-xgbe: Enable IRQs only if napi_complete_done() is
 true

On 3/9/2017 8:31 PM, David Miller wrote:
> From: Tom Lendacky <thomas.lendacky@....com>
> Date: Thu, 9 Mar 2017 17:48:23 -0600
>
>> Depending on the hardware, the amd-xgbe driver may use disable_irq_nosync()
>> and enable_irq() when an interrupt is received to process Rx packets. If
>> the napi_complete_done() return value isn't checked an unbalanced enable
>> for the IRQ could result, generating a warning stack trace.
>>
>> Update the driver to only enable interrupts if napi_complete_done() returns
>> true.
>>
>> Reported-by: Jeremy Linton <jeremy.linton@....com>
>> Signed-off-by: Tom Lendacky <thomas.lendacky@....com>
>
> Applied, thanks.

Thanks David!  The change to napi_complete_done() from void to bool
occurred in 4.10, can you queue this fix up against 4.10 stable?

Thanks,
Tom

>