netdev - Re: [PATCH next 0/5] bonding: winter cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170309.173352.1958436790967931477.davem@davemloft.net>
Date:   Thu, 09 Mar 2017 17:33:52 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     mahesh@...dewar.net
Cc:     j.vosburgh@...il.com, andy@...yhouse.net, vfalico@...il.com,
        nikolay@...hat.com, edumazet@...gle.com, netdev@...r.kernel.org,
        maheshb@...gle.com
Subject: Re: [PATCH next 0/5] bonding: winter cleanup

From: Mahesh Bandewar <mahesh@...dewar.net>
Date: Wed,  8 Mar 2017 10:55:45 -0800

> Few cleanup patches that I have accumulated over some time now.
> 
> (a) First two patches are basically to move the work-queue initialization
>     from every ndo_open / bond_open operation to once at the beginning while
>     port creation. Work-queue initialization is an unnecessary operation
>     for every 'ifup' operation. However we have some mode-specific work-queues
>     and mode can change anytime after port creation. So the second patch is
>     to ensure the correct work-handler is called based on the mode.
> 
> (b) Third patch is simple and straightforward that removes hard-coded value
>     that was added into the initial commit and replaces it with the default
>     value configured.
> 
> (c) The final patch in the series removes the unimplemented "port-moved" state
>     from the LACP state machine. This state is defined but never set so
>     removing from the state machine logic makes code little cleaner.
> 
> (d) Reduce scope of some global variables to local.
> 
> Note: None of these patches are making any functional changes.

This series looks fine to me, applied to net-next, thanks!